Skip to content

feat(watcher): partial git refresh #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

alex-courtis
Copy link
Member

@alex-courtis alex-courtis commented Jun 26, 2022

First PR of many. These can be incrementally merged.

Optimising watchers has two parts:

  1. git refresh
  2. file system refresh

Preventing concurrency for both is a problem as they cover a different set of files.

Avoid this problem for directory watchers by only git refreshing the sub-tree and making the sets of files the same.

Experimentation has shown that this is a substantial time save: ~1/20th for my large test repo

Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a great change :) Please just answer my question and feel free to merge if you feel it's not valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants